change the zoom-overlay position to fix #70 #78
Conversation
|
Awesome effort, but this doesn't fix the issue we were describing. Read this: #77 |
|
@ElegantSudo Thanks. My code LGTM for me and just fix #70 . What you described in #77 is anther way to fix the problem, I think.. |
|
It's evident that the author doesn't care. I'm developing a fix right now to the problem. I tried yours out, but it wasn't working. |
|
ahh, How about having a try: change the one line code document.body.appendChild(this._overlay)to this._targetImageWrap.parentNode.insertBefore(this._overlay, this._targetImageWrap)It works for me only changed this. 😝I just tried it again. |
|
@geekplux In my case, that doesn't work. If I do that, the white overlay won't show and the image is still cut off when it overflows its parent. |
|
hmm..Do you make sure your CSS and JS are the latest? |
|
You can refer to this: https://jsfiddle.net/GeekPlux/rym45g8c/ and..now is 3:30 am, I'm going to sleep ;) thank you again. |
fix #70
change the zoom-overlay position from the
<body>child to.zoom-img-wrapbro.