Open
Conversation
…ded automatically if run as privileged user
… install/uninstall commands to frpc/frps (run as privileged user)
…t unsafeFeatures)
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (7 files)
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if err != nil { | ||
| return nil | ||
| } | ||
| if len(keyNames) == 1 && keyNames[0] == "Frp" { |
There was a problem hiding this comment.
WARNING: The cleanup condition can never be true, so the Frp event log key is never removed after uninstall. registry.OpenKey() opens ...\EventLog\Frp, so ReadSubKeyNames() returns child source names like the service name, not Frp itself. With the current len(keyNames) == 1 && keyNames[0] == "Frp" check, the parent key is leaked every time the last service source is deleted.
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
Author
|
顶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
重新提交#5004
实现 #2468 ，可直接使用
sc.exe(cmd)/New-Service(powershell)/注册表将frps或frpc注册为服务（可使用LocalService、服务账户等提高安全性）已实现：
golang.org/x/sys/windows/svc包，使frps和frpc符合Windows服务程序规范golang.org/x/sys/windows/svc/eventlog包，为Logger添加Windows事件日志后端（可使用Windows事件查看器查看）-c的参数和install命令间需插入--；使用uninstall命令以卸载；会同时注册/移除事件源；需在管理员cmd/powershell中执行；默认使用LocalSystem身份，restricted模式使用NT AUTHORITY\LocalService和受限SID）