nathole: return error when SetTTL fails in sendSidMessage#5261
Open
cuiweixie wants to merge 1 commit intofatedier:devfrom
Open
nathole: return error when SetTTL fails in sendSidMessage#5261cuiweixie wants to merge 1 commit intofatedier:devfrom
cuiweixie wants to merge 1 commit intofatedier:devfrom
Conversation
Previously sendSidMessage logged SetTTL failures but continued, so the packet could be sent with an unexpected TTL. Align with TTL() failure handling by propagating the error.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
|
Owner
|
I don’t see a clear bug being fixed here. SetTTL failure in this path is currently handled as a best-effort degradation, and this PR changes it into a hard error without a concrete failure scenario or evidence that it is the right tradeoff. In general, please avoid sending PRs of this kind unless there is a clear abnormal case, reproducible issue, or demonstrated benefit. Otherwise they add review and maintenance cost without solving a concrete problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetTTLerrors insendSidMessageinstead of only logging and continuing, so UDP is not sent with an unintended TTL when TTL setup fails.TTL()failures in the same path.Context
Per Contributing, PR targets dev.