ENG-6200: Separate pure http handling into apiRequest
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickpintor
force-pushed
the
streaming-http
branch
from
9b03732
to
a7ec4e7
Compare
erickpintor
force-pushed
the
streaming-http
branch
from
a7ec4e7
to
0b629f2
Compare
pnwpedro
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm extracting the portion of the code that builds an HTTP request into a base struct so that I can re-use this code build the streaming request. As side benefit, I'm caching URL parsing to avoid that cost on every request. All changed types are internal so, I expect no user impact.