Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming support #153

Merged
merged 14 commits into from
May 20, 2024
Merged

Add streaming support #153

merged 14 commits into from
May 20, 2024

Conversation

pnwpedro
Copy link
Collaborator

Ticket(s): BT-4856

Merge streaming into main to prepare for release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

erickpintor and others added 12 commits April 26, 2024 09:01
@erickpintor
ENG-6200: Separate pure http handling into apiRequest (#137)
23c813d
@erickpintor
ENG-6203: Encode/decode stream token values (#139)
000ebf9
@erickpintor
ENG-6200: Turn client timeout into a response header timeout (#138)
4a7a656
@erickpintor
ENG-6204: Implement token based streaming (#140)
5ecec77
@erickpintor
ENG-6205: Allow to resume a stream at a given timestamp (#141)
1209a46
@erickpintor
ENG-6206: Introduce syntax sugar for simple streams (#142)
dfa693f
@erickpintor
ENG-6207: Resume streams after a network error (#143)
cc3da98
@erickpintor
Minor: flip arguments to require.Equal (and alike) (#144)
db761b0
@erickpintor
Document closing behavior when using http1x (#146)
be555c2
@erickpintor @jrodewig
ENG-6237: Update README to include streaming examples (#148)
45e7ea3 
Co-authored-by: James Rodewig <james.rodewig@fauna.com>
@erickpintor
Fix crash recovery example (#149)
99fc1ca
@erickpintor
ENG-6269: take event as an argument on stream.Next(..) (#150)
18ba5da
@pnwpedro pnwpedro changed the title Streaming Add streaming support May 17, 2024
@pnwpedro pnwpedro mentioned this pull request May 17, 2024
Closed
jrodewig
jrodewig approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README changes LGTM. Thanks!

@pnwpedro pnwpedro requested a review from cynicaljoy May 17, 2024 12:58
erickpintor
erickpintor approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it!

@cynicaljoy cynicaljoy mentioned this pull request May 19, 2024
Merged
@pnwpedro pnwpedro merged commit 93d2b46 into main May 20, 2024
4 checks passed
@pnwpedro pnwpedro deleted the streaming branch May 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickpintor erickpintor erickpintor approved these changes

@jrodewig jrodewig jrodewig approved these changes

@cynicaljoy cynicaljoy Awaiting requested review from cynicaljoy

Assignees
No one assigned
Labels
pr/do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnwpedro @erickpintor @jrodewig