ENG-6593: Introduce support for stream event cursors #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
approved these changes
Aug 21, 2024
erickpintor
force-pushed
the
stream-cursor
branch
from
5432d91
to
f1413a9
Compare
pnwpedro
requested changes
Aug 23, 2024
erickpintor
force-pushed
the
stream-cursor
branch
from
f1413a9
to
d3cfe68
Compare
|
I've addressed all feedback. This should be ready for another pass. |
pnwpedro
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide support for the new per-event stream cursor.
Motivation and context
There's an edge case where resuming a stream from a txn time with lots of documents written could result in event loss. This approach fixes that edge case.
How was the change tested?
Unit tests included.
Screenshots (if appropriate):
NA
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.