Create multi-threading.py (example) #401
Conversation
There was a problem hiding this comment.
I think we still need to do a bit of research. But again, I'm not really sure if we can recommend a broken solution?
And I don't think you can prevent the input text from being overwritten, without taking control over the terminal. Unless you do some kind of queuing? 😕
But thanks for the PR anyway, it's a nice place to start the discussion! 👍
examples/multi-threading.py
Outdated
| t1 = threading.Thread(target=receive) | ||
| t2 = threading.Thread(target=send) | ||
| t1.start() | ||
| t2.start() |
There was a problem hiding this comment.
Do we need a join somewhere? Or is that automatically done?
There was a problem hiding this comment.
I removed one thread, and made the remaining thread daemonic. From what I gather this should get destroyed when the main program exits.
|
I've been investigating a bit, I'd guess that https://github.com/kennethreitz/requests/issues/2766 would make it possible to solve the thread safety problems, but our code needs to be implemented with thread safety in mind as well, so it might not be that simple! |
| t2.start() | ||
| # Clean-up on exit | ||
| except KeyboardInterrupt: | ||
| client1.logout() |
There was a problem hiding this comment.
I'd argue there's really not a big need to log out (it's not shown in the other examples, either)
| except KeyboardInterrupt: | ||
| client1.logout() | ||
| client2.logout() | ||
| sys.exit(0) |
There was a problem hiding this comment.
We should clean the client2 up properly instead. That can be done by setting Client.listening to False, and then wait for the thread to clean up afterwards, using Thread.join
There was a problem hiding this comment.
And then there'd be no need to make t1 daemonic
New example for simultaneous sending and receiving, as discussed in the last few comments on #396 .
I'm sure there are better ways of doing this, so please hit me with any ideas for improvement.
Also, the script is a little buggy when it comes to printing. For instance; if you are in the middle of writing something and you receive another message, it gets printed in the middle of what you are writing. I was unable to find a solution without importing a third-party library.