Conversation
STT Job 생성, 요약 조회/수정/발행 API 함수 및 React Query 훅 구현. AbortController 기반 STT 요청 취소 지원, setQueryData 캐시 전략 적용.
12 tasks
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughRetrospectives 기능의 API 레이어와 React Query 기반 훅들을 추가합니다. 엔드포인트 빌더, 타입 정의, API 래퍼(createSttJob, getSummary, updateSummary, publishSummary), 쿼리 키 유틸, 훅(useCreateSttJob, useSummary, useUpdateSummary, usePublishSummary) 및 재내보내기를 포함합니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (5)
src/features/retrospectives/hooks/useUpdateSummary.ts (1)
19-23:setQueryData에 명시적 제네릭 타입 추가 권장현재는
response.data의 타입에서 암묵적으로 추론됩니다.setQueryData<RetrospectiveSummaryResponse>를 명시하면useSummary의 캐시 타입과의 일치를 컴파일 타임에 강제할 수 있습니다.♻️ 제안 리팩토링
- queryClient.setQueryData( + queryClient.setQueryData<RetrospectiveSummaryResponse>( retrospectiveQueryKeys.summary(variables.meetingId), response.data )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/retrospectives/hooks/useUpdateSummary.ts` around lines 19 - 23, Add an explicit generic to the cache update so the cached shape is enforced at compile time: in useUpdateSummary (the onSuccess handler that calls queryClient.setQueryData with retrospectiveQueryKeys.summary(variables.meetingId)), change the call to use setQueryData<RetrospectiveSummaryResponse>(...) so the data written matches the useSummary cache type and any mismatches are caught by the compiler.src/features/retrospectives/hooks/useCreateSttJob.ts (1)
16-45: 컴포넌트 언마운트 시 진행 중인 STT 요청이 자동 취소되지 않음문제: 컴포넌트가 언마운트되어도
abortControllerRef를 정리하는 로직이 없어 HTTP 요청이STT_TIMEOUT까지 계속 실행됩니다.영향: 불필요한 서버 부하 및 네트워크 낭비. 단, TanStack Query v5가 언마운트된 컴포넌트의 상태 업데이트는 처리하지 않으므로 React 렌더링 오류는 없습니다.
대안:
useEffectcleanup에서 abort를 호출합니다.♻️ 제안 리팩토링
+import { useCallback, useEffect, useRef } from 'react' -import { useCallback, useRef } from 'react' export const useCreateSttJob = () => { const abortControllerRef = useRef<AbortController | null>(null) + useEffect(() => { + return () => { + abortControllerRef.current?.abort() + abortControllerRef.current = null + } + }, []) const mutation = useMutation<...>({🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/retrospectives/hooks/useCreateSttJob.ts` around lines 16 - 45, The hook useCreateSttJob currently never aborts in-flight requests on unmount; add a useEffect cleanup that calls abortControllerRef.current?.abort() and sets abortControllerRef.current = null (and optionally calls reset() if you want mutation state cleared) so any ongoing createSttJob request is cancelled when the component unmounts; place this useEffect in the same file alongside abortControllerRef and cancel, and ensure useEffect is imported from React so the controller is cleaned up on unmount.src/features/retrospectives/hooks/retrospectiveQueryKeys.ts (1)
4-5:summaries함수명과'summary'키 세그먼트 불일치 — 선택적 정리
summaries()함수 이름은 복수형이지만 실제 키 값은'summary'(단수)입니다. 외부에서 직접 사용되는 건summary(meetingId)뿐이므로, 아래처럼 간소화하면 혼동을 없앨 수 있습니다.♻️ 제안 리팩토링
export const retrospectiveQueryKeys = { all: ['retrospectives'] as const, - - summaries: () => [...retrospectiveQueryKeys.all, 'summary'] as const, - summary: (meetingId: number) => [...retrospectiveQueryKeys.summaries(), meetingId] as const, + summaries: () => [...retrospectiveQueryKeys.all, 'summaries'] as const, + summary: (meetingId: number) => [...retrospectiveQueryKeys.all, 'summaries', meetingId] as const, }혹은
summaries를 아예 제거하고summary만 유지해도 됩니다(현재summaries가 내부 전용이라면).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/retrospectives/hooks/retrospectiveQueryKeys.ts` around lines 4 - 5, The key segment name is inconsistent: retrospectiveQueryKeys.summaries() returns a key segment using the literal 'summary' (singular) while the function name is plural; update for clarity by either renaming the literal to 'summaries' to match retrospectiveQueryKeys.summaries(), or remove the summaries() helper entirely and have retrospectiveQueryKeys.summary(meetingId) produce the full key directly; edit the functions retrospectiveQueryKeys.summaries and retrospectiveQueryKeys.summary so their names and returned key segments match (or drop the unused summaries helper).src/features/retrospectives/retrospectives.types.ts (1)
33-36:KeyPoint와KeyPointUpdateRequest가 구조적으로 동일 — 타입 중복두 타입의 형태가 완전히 같습니다. 요청/응답 스키마가 앞으로도 동일하게 유지될 것이라면
KeyPointUpdateRequest를 별도로 정의하는 대신KeyPoint를 재사용하는 것이 좋습니다.♻️ 리팩토링 제안
-/** 주요 포인트 수정 요청 */ -export type KeyPointUpdateRequest = { - title: string - details: string[] -} +/** 주요 포인트 수정 요청 (KeyPoint와 동일 형태) */ +export type KeyPointUpdateRequest = KeyPointAlso applies to: 59-62
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/retrospectives/retrospectives.types.ts` around lines 33 - 36, The KeyPoint and KeyPointUpdateRequest types are identical; remove the duplicate by reusing KeyPoint for update requests—either delete KeyPointUpdateRequest and export a type alias like "export type KeyPointUpdateRequest = KeyPoint" or have KeyPointUpdateRequest extend KeyPoint; update any usages referencing KeyPointUpdateRequest to use the alias or KeyPoint to avoid repeating the same shape (apply the same change for the second duplicate around the symbols mentioned at lines 59-62).src/features/retrospectives/retrospectives.api.ts (1)
59-91:updateSummary/publishSummary는api.patch/post헬퍼로 통일하기
getSummary는api.get을 사용하지만, 뮤테이션 함수들은apiClient.patch/post를 직접 호출합니다. 서버 응답이 동일하게ApiResponse<T>래퍼 구조이므로, 모든 API 함수에서 일관되게api헬퍼를 사용하면 반환 타입이 모두Promise<T>로 통일됩니다.수정 제안
-export const updateSummary = async (params: UpdateSummaryParams) => { - const { meetingId, data } = params - const response = await apiClient.patch<ApiResponse<RetrospectiveSummaryResponse>>( - RETROSPECTIVES_ENDPOINTS.SUMMARY(meetingId), - data - ) - return response.data -} +export const updateSummary = async ( + params: UpdateSummaryParams +): Promise<RetrospectiveSummaryResponse> => { + const { meetingId, data } = params + return api.patch<RetrospectiveSummaryResponse>( + RETROSPECTIVES_ENDPOINTS.SUMMARY(meetingId), + data + ) +} -export const publishSummary = async (params: PublishSummaryParams) => { - const response = await apiClient.post<ApiResponse<RetrospectiveSummaryResponse>>( - RETROSPECTIVES_ENDPOINTS.PUBLISH(params.meetingId) - ) - return response.data -} +export const publishSummary = async ( + params: PublishSummaryParams +): Promise<RetrospectiveSummaryResponse> => { + return api.post<RetrospectiveSummaryResponse>( + RETROSPECTIVES_ENDPOINTS.PUBLISH(params.meetingId) + ) +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/retrospectives/retrospectives.api.ts` around lines 59 - 91, The mutation helpers updateSummary and publishSummary currently call apiClient.patch/post and return response.data; change them to use the shared api helper (api.patch and api.post) like getSummary does so the functions return Promise<RetrospectiveSummaryResponse> directly; update updateSummary (which calls RETROSPECTIVES_ENDPOINTS.SUMMARY(meetingId)) and publishSummary (RETROSPECTIVES_ENDPOINTS.PUBLISH(params.meetingId)) to use api.patch/api.post and return the typed payload (RetrospectiveSummaryResponse) for consistent return types across the module.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/features/retrospectives/hooks/useCreateSttJob.ts`:
- Line 1: Prettier formatting in
src/features/retrospectives/hooks/useCreateSttJob.ts is failing CI; run the
formatter (e.g., run prettier --write on this file or your repo) to fix
whitespace/format changes around the import statements and any remaining
formatting issues in the useCreateSttJob hook so the import { useMutation } from
'@tanstack/react-query' and surrounding code conform to project Prettier rules.
- Around line 32-34: The current onSettled handler unconditionally clears
abortControllerRef.current causing a race where a later mutate() stores a new
controller then a prior mutation's onSettled wipes it; remove the onSettled
option and instead clear abortControllerRef.current inside the STT mutation
function (mutationFn) in its .finally() callback only if the ref still points to
that mutation's AbortController (i.e., check identity equality before nulling),
so cancel() + immediate mutate() won't erase a new controller; update references
to abortControllerRef, mutate, cancel, and mutationFn accordingly.
In `@src/features/retrospectives/hooks/usePublishSummary.ts`:
- Around line 18-24: In usePublishSummary: make the setQueryData call explicit
by adding the RetrospectiveSummaryResponse generic (i.e.,
queryClient.setQueryData<RetrospectiveSummaryResponse>(retrospectiveQueryKeys.summary(variables.meetingId),
response.data)) to match useUpdateSummary, then run prettier --write to fix
formatting.
In `@src/features/retrospectives/hooks/useUpdateSummary.ts`:
- Line 1: Run Prettier on the file to fix CI formatting: format the file
containing useUpdateSummary.ts (specifically the import line "import {
useMutation, useQueryClient } from '@tanstack/react-query'") using your
project's Prettier settings (e.g. run prettier --write or use the repo's
formatting script), ensure imports and spacing conform to the project's Prettier
config, then stage and commit the formatted file so the CI warning is resolved.
In `@src/features/retrospectives/retrospectives.api.ts`:
- Line 1: Prettier formatting has failed in retrospectives.api.ts; fix by
running Prettier to reformat the file (e.g., run prettier --write on
retrospectives.api.ts or your repo's configured Prettier command), review the
changed file (retrospectives.api.ts), stage and commit the formatted changes,
and push so CI can re-run with the corrected formatting.
In `@src/features/retrospectives/retrospectives.endpoints.ts`:
- Line 1: The file retrospectives.endpoints.ts has Prettier formatting issues;
run the project's formatter (e.g., execute prettier --write on the file or run
the repo's format script) to fix spacing/linebreaks and ensure imports like
"import { API_PATHS } from '@/api'" conform to the project's Prettier config;
commit the rewritten file so CI no longer flags the Prettier error.
---
Nitpick comments:
In `@src/features/retrospectives/hooks/retrospectiveQueryKeys.ts`:
- Around line 4-5: The key segment name is inconsistent:
retrospectiveQueryKeys.summaries() returns a key segment using the literal
'summary' (singular) while the function name is plural; update for clarity by
either renaming the literal to 'summaries' to match
retrospectiveQueryKeys.summaries(), or remove the summaries() helper entirely
and have retrospectiveQueryKeys.summary(meetingId) produce the full key
directly; edit the functions retrospectiveQueryKeys.summaries and
retrospectiveQueryKeys.summary so their names and returned key segments match
(or drop the unused summaries helper).
In `@src/features/retrospectives/hooks/useCreateSttJob.ts`:
- Around line 16-45: The hook useCreateSttJob currently never aborts in-flight
requests on unmount; add a useEffect cleanup that calls
abortControllerRef.current?.abort() and sets abortControllerRef.current = null
(and optionally calls reset() if you want mutation state cleared) so any ongoing
createSttJob request is cancelled when the component unmounts; place this
useEffect in the same file alongside abortControllerRef and cancel, and ensure
useEffect is imported from React so the controller is cleaned up on unmount.
In `@src/features/retrospectives/hooks/useUpdateSummary.ts`:
- Around line 19-23: Add an explicit generic to the cache update so the cached
shape is enforced at compile time: in useUpdateSummary (the onSuccess handler
that calls queryClient.setQueryData with
retrospectiveQueryKeys.summary(variables.meetingId)), change the call to use
setQueryData<RetrospectiveSummaryResponse>(...) so the data written matches the
useSummary cache type and any mismatches are caught by the compiler.
In `@src/features/retrospectives/retrospectives.api.ts`:
- Around line 59-91: The mutation helpers updateSummary and publishSummary
currently call apiClient.patch/post and return response.data; change them to use
the shared api helper (api.patch and api.post) like getSummary does so the
functions return Promise<RetrospectiveSummaryResponse> directly; update
updateSummary (which calls RETROSPECTIVES_ENDPOINTS.SUMMARY(meetingId)) and
publishSummary (RETROSPECTIVES_ENDPOINTS.PUBLISH(params.meetingId)) to use
api.patch/api.post and return the typed payload (RetrospectiveSummaryResponse)
for consistent return types across the module.
In `@src/features/retrospectives/retrospectives.types.ts`:
- Around line 33-36: The KeyPoint and KeyPointUpdateRequest types are identical;
remove the duplicate by reusing KeyPoint for update requests—either delete
KeyPointUpdateRequest and export a type alias like "export type
KeyPointUpdateRequest = KeyPoint" or have KeyPointUpdateRequest extend KeyPoint;
update any usages referencing KeyPointUpdateRequest to use the alias or KeyPoint
to avoid repeating the same shape (apply the same change for the second
duplicate around the symbols mentioned at lines 59-62).
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/features/retrospectives/hooks/useCreateSttJob.ts`:
- Line 13: JSDoc in the useCreateSttJob hook currently uses the ambiguous phrase
"동기 API"; update that comment in useCreateSttJob to explicitly state that the
mutation issues an HTTP request and waits for the server response (i.e., the
request blocks until response), so developers understand the hook's flow —
replace "동기 API" with a clear description such as "서버 응답을 기다리는 동기적(블로킹) HTTP
요청이므로 mutation이 pending인 동안 로딩 오버레이를 표시합니다" and keep the rest of the explanation
intact.
---
Duplicate comments:
In `@src/features/retrospectives/hooks/useCreateSttJob.ts`:
- Around line 28-31: The onSettled handler unconditionally clears
abortControllerRef.current causing a race where calling cancel() then mutate()
lets the new mutation's controller be wiped by the previous mutation's
onSettled; remove the onSettled cleanup and instead perform cleanup inside the
mutation function (mutationFn) in its .finally() by creating a local
AbortController, assigning it to abortControllerRef.current when starting, and
only nulling abortControllerRef.current if abortControllerRef.current ===
localController to ensure you don't clear a newer controller; keep cancel()
logic unchanged to call abort on the current controller.
In `@src/features/retrospectives/retrospectives.endpoints.ts`:
- Line 1: Prettier formatting issues remain in this file; run prettier --write
on the changed files (including the import line referencing API_PATHS) to
auto-format the code, stage the updated file, and commit the formatted changes
so CI Prettier warnings are resolved.
- api 함수 api.* 헬퍼로 통일 - useCreateSttJob race condition 수정 - useCreateSttJob 언마운트 시 자동 취소 - KeyPointUpdateRequest 타입 alias로 변경
choiyoungae
approved these changes
Feb 22, 2026
haruyam15
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
📋 작업 내용
약속 회고 AI 요약 기능을 위한 API 레이어(타입, 엔드포인트, API 함수, React Query 훅)를 구현했습니다.
UI 작업(#93)에서 사용할 기반 코드입니다.
🔧 변경 사항
retrospectives.types.ts)retrospectives.endpoints.ts)retrospectives.api.ts)📸 스크린샷 (선택 사항)
N/A
📄 기타
관련 이슈: #94
UI 작업 이슈: #93 (이 PR에 의존)
Summary by CodeRabbit
릴리스 노트
New Features
Chores