Returning 502 on REIN #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addressed the linter warning, have renamed the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 86.73% 86.75% +0.02%
==========================================
Files 11 11
Lines 1726 1729 +3
==========================================
+ Hits 1497 1500 +3
Misses 155 155
Partials 74 74 ☔ View full report in Codecov by Sentry. |
drakkan
reviewed
Aug 6, 2024
|
Have a test for REIN, but I've added the other unimplemented commands in as well. Let me know if we want a test for each of them or a group test, or if just a listing is enough? |
|
Sure, why not. This gives some idea of future commands to support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
Adds the REIN command, and returns a 502 status when it is received. This behaviour matches VSFTPD, and clients seem to choke when getting a 500 on a technically valid command.
EDIT: Have also added the NotImplemented handler for other standard commands that have not been implemented. We'd want to send a 502 for any commands that are actually standardised but not implemented, none of these would be syntax errors (500) by default.