Reinstate user-agent header to ADDS requests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last Thursday, our requests to ADDS using this package started getting a
403 Forbiddenresponse. Curiously, our requests that did not use this package (and still used superagent 3.8 were still working. The only different we could see between the requests was this package was not sending auser-agentheader, while the old version of superagent was.Sure enough, superagent 5.1 removed the
user-agentheader.This PR adds a
user-agentheader to the requests, which appears to fix the problem. We are still unclear on exactly what or why changes were made by ADDS to require theuser-agent.