Create CI #2
Merged
Create CI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Nov 10, 2024
dfed
commented
Nov 10, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
19
to
20
| run: | | ||
| xcrun swift test -c release --enable-code-coverage -Xswiftc -enable-testing |
There was a problem hiding this comment.
I don't have permissions to set up Codecov in this repo so I didn't set that up. We’ll Get There™
dfed
commented
Nov 10, 2024
| - name: Checkout Repo | ||
| uses: actions/checkout@v4 | ||
| - name: Build and Test Framework | ||
| run: swift test -c release --enable-code-coverage -Xswiftc -enable-testing |
There was a problem hiding this comment.
this is becoming a habit of mine in open source libs: test in release!
makes things a bit slower in CI but I have caught a few esoteric issues this way.
There was a problem hiding this comment.
though testing in release on macOS yields an error executing the CLI, which... I don't get why. works on linux at least.
There was a problem hiding this comment.
Oh interesting! I've never thought about testing in release. Let's try it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.