Fix SDFCore module not found #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdiaz
commented
Nov 12, 2024
| @@ -51,6 +51,22 @@ final class MacroInitializerSorterTests { | |||
| """ | |||
| try await #expect(sut.run(onContent: content.rawValue).contains(expected)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is completely unnecessary for this issue, but it's how I discovered this was failing.
Basically I was wondering if the changes introduced in #4 would work still when the nested type contains the macro too, and I was validating with this unit test.
As expected, things work! So nothing to see here, but I think this unit test is still valuable so I decided to commit it anyways.
There was a problem hiding this comment.
SafeDI does not allow nested macros today, but certainly doesn't hurt to support this potential future case.
dfed
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've known executable targets have a problem when running unit tests on them, but since I haven't tried it in a couple of years I decided to give it another try with this package.
Even though things worked out locally and using the CLI, it started failing for @dfed when he pulled the repo, and after pulling the latest version the same happened to me.
To be safe, I created a new CLI target that contains the parsing of the arguments and delegates the rest to the SDFCore target for uni testing.