fix(owner-tool): use the new API to export ovs #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see some unit tests for this. We lacked unit tests in #673, too. We can do better! 💪 |
these functionalities are (to me) better covered with functional tests (which both this and #673 already have) - the remaining part is rust's warp wrapping which I'm not sure we need to cover (as we already run the tool, effectively excercising the paths here) |
runcom
force-pushed
the
owner-tool-export
branch
from
5d35b66
to
50f5c22
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
runcom
force-pushed
the
owner-tool-export
branch
2 times, most recently
from
7b32e9e
to
7202ee7
Compare
|
ready for review now! |
This change allows the use of the new REST API to export either a single ov or multiple (tar-ed up). Signed-off-by: Antonio Murdaca <amurdaca@redhat.com>
runcom
force-pushed
the
owner-tool-export
branch
from
7202ee7
to
0c6b2c5
Compare
mmartinv
reviewed
Oct 3, 2024
mmartinv
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the use of the new REST API to export either a single ov or multiple (tar-ed up).
Tested with the following: