Add product to favourites #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSchmide
suggested changes
Sep 4, 2023
src/components/Card.tsx
Outdated
| }; // See if the product id is in the favoriteItems array | ||
|
|
||
| const handleClick = (currentProduct: IProduct) => { | ||
| if (hasProductId(currentProduct._id)) { |
There was a problem hiding this comment.
Use one action, toggleFavorite, where u will check is product in fav by id
perfectAcedia
approved these changes
Sep 4, 2023
MaxSchmide
suggested changes
Sep 4, 2023
src/pages/FavouritesPage.tsx
Outdated
Comment on lines
11
to
29
|
|
||
| // eslint-disable-next-line no-console | ||
| // const [products, setProducts] = useState<IProduct[]>([]); | ||
| // #endregion | ||
|
|
||
| // #region rewrite to RTQ Query | ||
| useEffect(() => { | ||
| axios | ||
| .get('https://dreamteam.onrender.com/products', { | ||
| params: { page: 1, perPage: 8 }, | ||
| }) | ||
| .then((res) => { | ||
| setProducts(res.data.data); | ||
| }) | ||
| .catch((e) => { | ||
| throw new Error(e); | ||
| }); | ||
| }, []); | ||
| // useEffect(() => { | ||
| // axios | ||
| // .get('https://dreamteam.onrender.com/products', { | ||
| // params: { page: 1, perPage: 8 }, | ||
| // }) | ||
| // .then((res) => { | ||
| // setProducts(res.data.data); | ||
| // }) | ||
| // .catch((e) => { | ||
| // throw new Error(e); | ||
| // }); | ||
| // }, []); | ||
| // #endregion |
src/hooks/useLocalStorage.ts
Outdated
Comment on lines
1
to
10
| import { useEffect } from 'react'; | ||
| import { getInitialFavourites, useAppDispatch } from '../redux/'; | ||
|
|
||
| export const useInitFavourites = () => { | ||
| const dispatch = useAppDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| dispatch(getInitialFavourites()); | ||
| }, []); | ||
| }; |
There was a problem hiding this comment.
GJ, but, please, rename file to your hook name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.