Phones from api #19
Merged
Phones from api #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfectAcedia
approved these changes
Sep 5, 2023
NazarBaraban
approved these changes
Sep 5, 2023
olena-ole
previously requested changes
Sep 5, 2023
src/pages/CatalogPage.tsx
Outdated
| import { Dropdown } from '../components/Dropdown'; | ||
| import { Card } from '../components/Card'; | ||
| import axios from 'axios'; | ||
| // import axios from 'axios'; |
MaxSchmide
suggested changes
Sep 5, 2023
src/redux/api/product.ts
Outdated
Comment on lines
1
to
14
| import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query/react'; | ||
|
|
||
| export const productApi = createApi({ | ||
| baseQuery: fetchBaseQuery({ | ||
| baseUrl: 'https://dreamteam.onrender.com', | ||
| }), | ||
| endpoints: (builder) => ({ | ||
| getProducts: builder.query({ | ||
| query: () => `/products`, | ||
| }), | ||
| }), | ||
| }); | ||
|
|
||
| export const { useGetProductsQuery } = productApi; |
There was a problem hiding this comment.
rename file to your func
Comment on lines
+46
to
+50
| } = useGetProductsQuery({ | ||
| perPage, | ||
| page: currentPage, | ||
| sortBy, | ||
| }); |
There was a problem hiding this comment.
here u passing props but your query doesn't accept them
src/redux/api/product.ts
Outdated
Comment on lines
8
to
10
| getProducts: builder.query({ | ||
| query: () => `/products`, | ||
| }), |
There was a problem hiding this comment.
here you need accept those props and return the object like ({})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.