ledger: show reconnect dialog if ledger is locked during sync

feather-wallet · Dec 18, 2024 · f423059 · f423059
1 parent 1e3bc66
commit f423059
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 13 deletions.
diff --git a/monero b/monero
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -1431,7 +1431,7 @@ void MainWindow::importTransaction() {
     dialog.exec();
 }
 
-void MainWindow::onDeviceError(const QString &error) {
+void MainWindow::onDeviceError(const QString &error, quint64 errorCode) {
     qCritical() << "Device error: " << error;
 
     if (m_showDeviceError) {
@@ -1441,7 +1441,13 @@ void MainWindow::onDeviceError(const QString &error) {
     m_statusBtnHwDevice->setIcon(this->hardwareDeviceUnpairedIcon());
     while (true) {
         m_showDeviceError = true;
-        auto result = QMessageBox::question(this, "Hardware device", "Lost connection to hardware device. Attempt to reconnect?");
+
+        QString prompt = "Lost connection to hardware device. Attempt to reconnect?";
+        if (errorCode == 0x5515) {
+            prompt = QString("Device must be unlocked to continue scanning. Attempt to continue?");
+        }
+
+        auto result = QMessageBox::question(this, "Hardware device", prompt);
         if (result == QMessageBox::Yes) {
             bool r = m_wallet->reconnectDevice();
             if (r) {

diff --git a/src/MainWindow.h b/src/MainWindow.h
@@ -161,7 +161,7 @@ private slots:
     void onResendTransaction(const QString &txid);
     void importContacts();
     void importTransaction();
-    void onDeviceError(const QString &error);
+    void onDeviceError(const QString &error, quint64 errorCode);
     void onDeviceButtonRequest(quint64 code);
     void onDeviceButtonPressed();
     void onWalletPassphraseNeeded(bool on_device);

diff --git a/src/WindowManager.cpp b/src/WindowManager.cpp
@@ -608,7 +608,7 @@ void WindowManager::onDeviceButtonPressed() {
     m_splashDialog->hide();
 }
 
-void WindowManager::onDeviceError(const QString &errorMessage) {
+void WindowManager::onDeviceError(const QString &errorMessage, quint64 errorCode) {
     // TODO: when does this get called?
     qCritical() << Q_FUNC_INFO << errorMessage;
 }

diff --git a/src/WindowManager.h b/src/WindowManager.h
@@ -68,7 +68,7 @@ private slots:
     void onInitialNetworkConfigured();
     void onDeviceButtonRequest(quint64 code);
     void onDeviceButtonPressed();
-    void onDeviceError(const QString &errorMessage);
+    void onDeviceError(const QString &errorMessage, quint64 errorCode);
     void onWalletPassphraseNeeded(bool on_device);
     void onChangeTheme(const QString &themeName);
 

diff --git a/src/libwalletqt/Wallet.h b/src/libwalletqt/Wallet.h
@@ -441,7 +441,7 @@ Q_OBJECT
     void walletCreationHeightChanged();
     void deviceButtonRequest(quint64 buttonCode);
     void deviceButtonPressed();
-    void deviceError(const QString &message);
+    void deviceError(const QString &message, quint64 errorCode);
     void walletPassphraseNeeded(bool onDevice);
     void beginCommitTransaction();
     void transactionCommitted(bool status, PendingTransaction *t, const QStringList& txid, const QMap<QString, QString> &txHexMap);

diff --git a/src/libwalletqt/WalletListenerImpl.cpp b/src/libwalletqt/WalletListenerImpl.cpp
@@ -73,10 +73,10 @@ void WalletListenerImpl::onDeviceButtonPressed()
     emit m_wallet->deviceButtonPressed();
 }
 
-void WalletListenerImpl::onDeviceError(const std::string &message)
+void WalletListenerImpl::onDeviceError(const std::string &message, unsigned int error_code)
 {
     qDebug() << __FUNCTION__;
-    emit m_wallet->deviceError(QString::fromStdString(message));
+    emit m_wallet->deviceError(QString::fromStdString(message), error_code);
 }
 
 void WalletListenerImpl::onPassphraseEntered(const QString &passphrase, bool enter_on_device, bool entry_abort)

diff --git a/src/libwalletqt/WalletListenerImpl.h b/src/libwalletqt/WalletListenerImpl.h
@@ -31,7 +31,7 @@ class WalletListenerImpl : public Monero::WalletListener, public PassphraseRecei
 
     virtual void onDeviceButtonPressed() override;
 
-    virtual void onDeviceError(const std::string &message) override;
+    virtual void onDeviceError(const std::string &message, unsigned int error_code) override;
 
     virtual void onPassphraseEntered(const QString &passphrase, bool enter_on_device, bool entry_abort) override;
 

diff --git a/src/libwalletqt/WalletManager.cpp b/src/libwalletqt/WalletManager.cpp
@@ -43,10 +43,10 @@ class WalletPassphraseListenerImpl : public Monero::WalletListener, public Passp
         emit m_mgr->deviceButtonPressed();
     }
 
-    void onDeviceError(const std::string &message) override
+    void onDeviceError(const std::string &message, unsigned int error_code) override
     {
         qDebug() << __FUNCTION__;
-        emit m_mgr->deviceError(QString::fromStdString(message));
+        emit m_mgr->deviceError(QString::fromStdString(message), error_code);
     }
 
 private:

diff --git a/src/libwalletqt/WalletManager.h b/src/libwalletqt/WalletManager.h
@@ -121,7 +121,7 @@ class WalletManager : public QObject, public PassphrasePrompter
     void walletPassphraseNeeded(bool onDevice);
     void deviceButtonRequest(quint64 buttonCode);
     void deviceButtonPressed();
-    void deviceError(const QString &message);
+    void deviceError(const QString &message, quint64 errorCode);
     void openAliasResolved(const QString &alias, const QString &address, bool dnssecValid);
 
 private:
+1 −1		src/device/device.hpp
+8 −0		src/device/device_ledger.cpp
+1 −0		src/device/device_ledger.hpp
+2 −2		src/wallet/api/wallet.cpp
+1 −1		src/wallet/api/wallet2_api.h
+5 −5		src/wallet/wallet2.cpp
+3 −3		src/wallet/wallet2.h