Fix issue with EF Core saying the key is missing #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the type has the `[Key]` attribute, the change to the explicit interface Id property broke EF Core's key detection. I believe this is fundamentally an EF Core bug, but we can work around it by explicitly specifying the key in the context builder logic.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an EF Core key detection issue that occurred after changing the Id property to an explicit interface implementation. The fix explicitly configures the primary key in the DbContext's OnModelCreating method.
- Adds explicit key configuration for SyncLogEntry entity in EF Core context
- Adds comprehensive test coverage for the SyncLogDbContext functionality
- Includes Entity Framework Core InMemory package for testing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Syncerbell.Tests/Syncerbell.Tests.csproj | Adds EF Core InMemory package and project reference for testing |
| Syncerbell.Tests/SyncLogDbContextTests.cs | Comprehensive test suite covering CRUD operations and EF Core functionality |
| Syncerbell.EntityFrameworkCore/SyncLogDbContext.cs | Explicitly configures primary key to fix EF Core key detection issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the type has the
[Key]attribute, the change to the explicit interface Id property broke EF Core's key detection. I believe this is fundamentally an EF Core bug, but we can work around it by explicitly specifying the key in the context builder logic.