Skip to content

Conversation

@paulirwin
Copy link
Member

No description provided.

@paulirwin paulirwin requested a review from Copilot August 4, 2025 19:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the registration of IDbContextFactory<SyncLogDbContext> from the dependency injection container in the Entity Framework Core persistence setup.

  • Removes the AddDbContextFactory<SyncLogDbContext> service registration
Comments suppressed due to low confidence (1)

Syncerbell.EntityFrameworkCore/ServiceCollectionExtensions.cs:24

  • Removing IDbContextFactory registration may break existing code that depends on it for creating DbContext instances in scenarios like background services or when multiple instances are needed. Consider documenting this breaking change or providing an alternative registration method if the factory is still needed.
        services.AddDbContext<SyncLogDbContext>(options.ConfigureDbContextOptions);

@paulirwin paulirwin merged commit ba4b808 into main Aug 4, 2025
1 check passed
@paulirwin paulirwin deleted the bugfix/singleton-factory branch August 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants