Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to cloud.gov #17

Merged
merged 30 commits into from
Feb 7, 2022
Merged

Deploy to cloud.gov #17

merged 30 commits into from
Feb 7, 2022

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Jan 27, 2022

Summary of changes

Steps to test (QA)

Testing URLS
https://fecfile-web-api-dev.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-stage.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-prod.app.cloud.gov/api/v1/token/obtain

Steps to test/additional developer information (devs)

Deploy with invoke

  • Log in to cloud.gov with cf login --sso
  • invoke deploy --space dev

Deploy with CircleCI

  • Make a copy of this branch
  • Change deploy rules to deploy your branch
  • Commit/push to github

Locally

  • Set DATABASE_URL?
  • Run with Docker

(Optional) Create RDS

  • cf create-service aws-rds small-psql-redundant fecfile-api-rds
  • Wait for db creation
  • Bind to app in manifest, redeploy

(Optional) Restore database from backup

Testing URLS
https://fecfile-web-api-dev.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-stage.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-prod.app.cloud.gov/api/v1/token/obtain

.cfignore Outdated Show resolved Hide resolved
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch 2 times, most recently from 8d86b79 to 542cd1a Compare February 1, 2022 20:10
@lbeaufort lbeaufort marked this pull request as draft February 2, 2022 14:46
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 542cd1a to 5b6db87 Compare February 2, 2022 14:54
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 5b6db87 to 0f51b0c Compare February 2, 2022 15:04
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 91ee60d to 1d46abc Compare February 2, 2022 18:17
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 66b376c to 6e731bd Compare February 2, 2022 18:38
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 7d82f21 to e76fe97 Compare February 2, 2022 19:11
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 25d0d92 to d3df60e Compare February 2, 2022 19:37
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch 2 times, most recently from 1954785 to 66ec919 Compare February 2, 2022 22:11
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 66ec919 to 45f579b Compare February 2, 2022 22:16
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from b0e5bc2 to c303f9c Compare February 2, 2022 22:42
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 229807c to 5f93611 Compare February 3, 2022 14:33
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch 3 times, most recently from bd42b3d to d6f5034 Compare February 3, 2022 17:22
@lbeaufort lbeaufort marked this pull request as ready for review February 3, 2022 17:27
@lbeaufort lbeaufort changed the title [WIP] Deploy to cloud.gov Deploy to cloud.gov Feb 3, 2022
@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from 271262b to 2e04741 Compare February 3, 2022 19:38
Copy link
Contributor

@albertcrowley albertcrowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put inline comments in the PR. The summary is:

  • I have a question about the Python version we should be using in general for our CI and dev containers.
  • I'm seeing CORS errors in the web console when talking to the cloud.gov API so we need to either fix that up or spin it out to a new issue for later.

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
django-backend/fecfiler/settings/production.py Outdated Show resolved Hide resolved
django-backend/fecfiler/settings/base.py Outdated Show resolved Hide resolved
@lbeaufort lbeaufort requested a review from mjtravers February 4, 2022 21:07
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of stuff. Good code clean up, too.

@lbeaufort lbeaufort force-pushed the feature/40-test-cloud-gov branch from aaa2da1 to 4ee568c Compare February 7, 2022 14:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

@lbeaufort lbeaufort merged commit 735c198 into develop Feb 7, 2022
@lbeaufort lbeaufort deleted the feature/40-test-cloud-gov branch February 7, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants