file based logging #598
Merged
file based logging #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sarob
commented
Oct 25, 2024
sarob
commented
- implements /log/app.log
- app_config.py has new vars
- LOG_TO_FILE
- LOG_TO_CONSOLE
- thread pooling fixes to support file logging
- to support the PR changes - making Hawk to evaluate before applying to job #555
for tracing how well the suitability code is working
|
when logging is concerned - we need to have module-based logging. As of now we used same logger entire code base, as the result we can't set log level at module levels which increases debugging time and other lot of impacts. |
- more log file mgmt
|
Hi @sarob can you separate logging from utils.py. like having logging.py which can take care of configuring and managing logger |
surapuramakhil
suggested changes
Oct 27, 2024
|
Will do tomorrow morning. Sean ***@***.*** On Oct 26, 2024, at 20:01, Akhil ***@***.***> wrote:
@surapuramakhil requested changes on this pull request.
Everything is good. Only 1 thing is required. we can move logging configuration from utils.py to separate file logging.py
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I need @feder-cr to resolve the conflict while repo rights and roles are being worked out. I have the suggested changes to move log functions to logging.py ready to push. |
surapuramakhil
approved these changes
Oct 27, 2024
- updates tests and code to use src/logging - exclude log files
for tracing how well the suitability code is working
- more log file mgmt
- updates tests and code to use src/logging - exclude log files
|
tests pass and double checked functionality |
HuseynA28
pushed a commit
to HuseynA28/Auto_Applier
that referenced
this pull request
Nov 11, 2024
DanielT504
pushed a commit
to DanielT504/Auto_Jobs_Applier_AI_Agent
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.