-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extraction chains #458
extraction chains #458
Conversation
@feder-cr opened a new PR for V4 as you asked. |
@MrTpat please explain better the PR |
@feder-cr was the description of the original PR not sufficient? |
@MrTpat copy and paste here |
@feder-cr updated. |
@MrTpat please on V4 |
@feder-cr it is on v4, but the tests are failing. i don't quite have the time to fix the tests, if someone else wants to pick this work up please go ahead! |
@feder-cr i fixed the tests. can you merge? |
Hey @MrTpat, I’ve gone over the files you modified, but I believe this method will also fail if LinkedIn updates their class names. So, I think neither your approach nor mine is ideal for the program. Let's have a conversation to figure out a better solution. What do you think? No offense intended. |
@RushiChaganti the idea is that once linkedin updates their class names, someone can add an extraction chain implementation that adheres to that class change. |
@MrTpat very good idea, but please on V4 |
@feder-cr im confused what you mean by "please on V4". are you asking me to rebase? |
981b2c1
to
e9efa34
Compare
i need this on https://github.com/feder-cr/Auto_Jobs_Applier_AIHawk/tree/v4 |
e9efa34
to
0cbd725
Compare
@feder-cr done. |
@MrTpat I'm interested did this get published in the end? |
@moudimash99 there are not in release yet. PR to track & participate in reviews providing your feedback. |
So this introduces a concept of "extraction chains" for our job parsing. Certain issues: (#114) are happening because there are parsing changes necessary when LinkedIn changes something on their end. Instead of changing our parsing code each time, we can add a new parser here when we encounter some new linkedin HTML format.
Shoutout to @pafthinder for his initial correct implementation which I've included here. This fixes THAT issue and fixes issues I had been having myself.