690 #693
Merged
690 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v11.08.2024
|
I will test it and make a judgement as soon as possible. Some cases like "phone number" maybe can be used for all companies. |
I don't understand your point? It is checking if the company name is in the answer you probably don't want to reuse those answers |
sloganking
reviewed
Oct 31, 2024
src/ai_hawk/linkedIn_easy_applier.py
Outdated
| @@ -844,10 +857,9 @@ def _save_questions_to_json(self, question_data: dict) -> None: | |||
| logger.error("JSON decoding failed") | |||
| data = [] | |||
|
|
|||
| # Use the new function to check for existing questions | |||
| question_exists = self._question_exists_in_data(question_data['question'], data) | |||
| should_be_saved: bool = not question_already_exists_in_data(question_data['question'], data) or self.answer_contians_company_name(question_data['answer']) | |||
There was a problem hiding this comment.
shouldn't this be AND instead of OR? And shouldn't it be NOT self.answer_contians_company_name instead of just self.answer_contians_company_name?
There was a problem hiding this comment.
Yes fixed
FrancescoVassalli
force-pushed
the
690
branch
from
9de36c6 to
da88f05
Compare
|
@FrancescoVassalli join on telegram group |
feder-cr
changed the base branch from
release/v11.08.2024
to
release/v11.01.2024
HuseynA28
pushed a commit
to HuseynA28/Auto_Applier
that referenced
this pull request
Nov 11, 2024
DanielT504
pushed a commit
to DanielT504/Auto_Jobs_Applier_AI_Agent
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #690