cli: remove dependency on simplejson #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fedora-copr#2539 The output of `json.dumps` and `simplejson.dumps` is equivalent for listing builds and listing packages. I am removing the `for_json` parameter because there is not equivalent. However it shouldn't make any difference because: > If for_json is true (not the default), objects with a for_json() > method will use the return value of that method for encoding as JSON > instead of the object. We don't define any `for_json` methods for our objects.
|
To my surprise this works even on EPEL7 |
praiskup
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2539
The output of
json.dumpsandsimplejson.dumpsis equivalent for listing builds and listing packages. I am removing thefor_jsonparameter because there is not equivalent. However it shouldn't make any difference because:We don't define any
for_jsonmethods for our objects.