backend: per-arch/per-owner limit fixed #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this patch, the per-arch limit was applied to all architectures. Fixes: fedora-copr#3574
|
Will anyone bless my attempt to hotfix this in prod? |
FrostyX
reviewed
Jan 6, 2025
| # When _hasher(job) returns None, no limit applies, see | ||
| # HashWorkerLimit._groups.add() for more info. | ||
| return None | ||
| return f"{job.requested_arch}_{job.owner}" |
There was a problem hiding this comment.
Returning None seems strange. Aren't we supposed to return some string, like this ^^ and something outside this class counts how many same strings are there and compare them to the limit?
There was a problem hiding this comment.
If we return None for a job, that particular one is not calculated; HashWorkerLimit uses StringCounter.add():
copr/common/copr_common/worker_manager.py
Lines 111 to 114 in 9d0d6f3
There was a problem hiding this comment.
I am reading the issue again, and I probably understand now. The None makes sense.
I think we can do that :-) |
|
OK to merge? |
FrostyX
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this patch, the per-arch limit was applied to all architectures.
Fixes: #3574