Skip to content

Allow unconfined_domain_type use IORING_OP_URING_CMD on self #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

5umm3r15
Copy link
Contributor

Addresses the following denial:

type=AVC msg=audit(1696506406.082:97818): avc: denied { cmd } for pid=541430 comm="io_uring_passth" path="/dev/ng2n1" dev="devtmpfs" ino=745 scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tcontext=system_u:object_r:fixed_disk_device_t:s0 tclass=io_uring permissive=0

Resolves: RHEL-11792

@WOnder93
Copy link
Member

In the AVC the target type doesn't match the source type, so something is wrong here. Isn't the AVC already covered by the dev_io_uring_cmd_on_all_dev_nodes(unconfined_domain_type) line?

@5umm3r15
Copy link
Contributor Author

@WOnder93 thank you, you are right, in the commit message was wrong denial.

The fix is for audit2allow output:
allow unconfined_t self:io_uring cmd;

@WOnder93
Copy link
Member

Yeah, I asked in RHEL-11792 for the full denial, because it looks suspicious.

Addresses the following denial:
[audit2allow output]
allow unconfined_t self:io_uring cmd;

Resolves: RHEL-11792
@5umm3r15
Copy link
Contributor Author

5umm3r15 commented Nov 5, 2023

Thanks @WOnder93, fixed
:)

@WOnder93
Copy link
Member

WOnder93 commented Nov 6, 2023

I think you misunderstood - I was proposing the following as the final result:

allow unconfined_domain_type domain:io_uring { cmd override_creds };
allow unconfined_domain_type self:io_uring sqpoll;

@zpytela
Copy link
Contributor

zpytela commented Nov 14, 2023

Thanks for your effort, closing in favor of #1937

@zpytela zpytela closed this Nov 14, 2023
@5umm3r15
Copy link
Contributor Author

@zpytela thanks for update and sorry for not delivering fix on time

@zpytela
Copy link
Contributor

zpytela commented Nov 20, 2023

No problem @5umm3r15, looking forward to your future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants