Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to dispose/release resources used by a repository created by the RepositoryProvider #4356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yerzhant
Copy link

@yerzhant yerzhant commented Feb 18, 2025

Status

READY

Breaking Changes

NO

Description

Allows to cleanup resources used in the created repo.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@yerzhant yerzhant requested a review from felangel as a code owner February 18, 2025 07:50
@yerzhant yerzhant changed the title Closes #4355 feat: allow to dispose/release resources used by a repository created by the RepositoryProvider Feb 21, 2025
@yerzhant
Copy link
Author

Hi @felangel,

may I kindly ask you to let me know when are you going to merge the changes, if, of course, you're going to accept the PR? And when should I expect it to appear on pub.dev?

Thanks in advance!

@felangel
Copy link
Owner

Hi @felangel,

may I kindly ask you to let me know when are you going to merge the changes, if, of course, you're going to accept the PR? And when should I expect it to appear on pub.dev?

Thanks in advance!

After thinking about it a bit more, I think the change is fine. I’ll try to get it merged and released in the next few days.

Key? key,
Widget? child,
bool? lazy,
}) : super(
key: key,
create: create,
dispose: (_, __) {},
dispose: dispose,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests for this change.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (14db8f3) to head (d57fddb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          806       805    -1     
=========================================
- Hits           806       805    -1     
Flag Coverage Δ
flutter_bloc 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants