Skip to content

Comments

feat: update output delimiter & include notes if present#12

Merged
felipecrs merged 5 commits intofelipecrs:masterfrom
carloscortonc:master
Oct 5, 2025
Merged

feat: update output delimiter & include notes if present#12
felipecrs merged 5 commits intofelipecrs:masterfrom
carloscortonc:master

Conversation

@carloscortonc
Copy link
Contributor

@carloscortonc carloscortonc commented Oct 5, 2025

Hi @felipecrs , first of all thank you for this plugin. I was looking for a way to preview the release on open PRs, and your plugin helped me with that.

One thing it was missing was nextRelease.notes, to easily preview and verify release notes. For that, I applied a patch to your npm module: https://github.com/carloscortonc/rpi-cli/blob/7adf997dade8ed5fe119a15165625002dec2c66b/patches/semantic-release-export-data%2B1.1.1.patch

Just exporting nextRelease.notes generated an error, because the content is multi-line (https://github.com/carloscortonc/rpi-cli/actions/runs/18257911158/job/51981820460#step:6:289)
I reviewed how @actions/core::setOutput solved it, and is by using a custom delimiter.

Proposed changes

The proposed changes are:

  • Include nextRelease.notes in a new output variable new-release-notes
  • Define custom delimiter so output-setting works with multi-line values

These changes in action can be seen here by using this workflow

@felipecrs
Copy link
Owner

@carloscortonc thanks for the contribution.

I made some changes in 2f3cc34.

Mind taking a look?

@felipecrs
Copy link
Owner

Release notes can be quite big. Logging it would be problematic. Besides, semantic-release already logs the release notes.

Also, release notes are always set as per semantic-release's type:

https://github.com/semantic-release/semantic-release/blob/422fb20fd45e8fd7f16273de5e68ad61168750e7/index.d.ts#L381

@carloscortonc
Copy link
Contributor Author

Looks fine @felipecrs 💯

@felipecrs felipecrs merged commit cea6a6b into felipecrs:master Oct 5, 2025
2 checks passed
@felipecrs
Copy link
Owner

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

carloscortonc added a commit to carloscortonc/rpi-cli that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants