[PR Feedback] Cleaned up argument logic

felipecrs · Sep 6, 2024 · 78e9079 · 78e9079
1 parent 499755f
commit 78e9079
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/verify-vsce-auth.js b/lib/verify-vsce-auth.js
@@ -4,22 +4,26 @@ const SemanticReleaseError = require('@semantic-release/error');
 const execa = require('execa');
 
 module.exports = async (logger, cwd) => {
-  if (!process.env.VSCE_PAT && !process.env.VSCE_AZURE_CREDENTIAL) {
+  const patAuth = 'VSCE_PAT' in process.env && process.env.VSCE_PAT;
+  const vsceAuth =
+    'VSCE_AZURE_CREDENTIAL' in process.env && process.env.VSCE_AZURE_CREDENTIAL;
+
+  if (!patAuth && !vsceAuth) {
     throw new SemanticReleaseError(
       'Neither vsce personal access token (`VSCE_PAT` environment variable) or Azure Credentials flag (`VSCE_AZURE_CREDENTIAL` environment variable) specified.',
       'EVSCEAUTHNOTPROVIDED',
     );
   }
 
-  if (process.env.VSCE_PAT && process.env.VSCE_AZURE_CREDENTIAL) {
+  if (patAuth && vsceAuth) {
     throw new SemanticReleaseError(
       'Both vsce personal access token (`VSCE_PAT` environment variable) or Azure Credentials flag (`VSCE_AZURE_CREDENTIAL` environment variable) specified.  Please use only one.',
       'EVSCEDUPLICATEAUTHPROVIDED',
     );
   }
 
   const vsceArgs = ['verify-pat'];
-  if (process.env.VSCE_AZURE_CREDENTIAL) {
+  if (vsceAuth) {
     vsceArgs.push('--azure-credential');
   }