Replace primitive type by struct to fix alignment #31
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(it looks like there's a ton of very strange test failures on a bunch of platforms, maybe the matrix is now too big? But looks like the important platforms - Ubuntu/x64 and macOS on both architectures - pass). |
|
@felipenoris do you need anything more from me? There's no super big hurry - we work off the fork and the moment and it's all fine - just want to wrap this up and get my To Do list one item shorter :-) |
|
Thanks @cdegroot! |
giordano
reviewed
Feb 19, 2025
| @@ -27,6 +27,7 @@ jobs: | |||
| - macOS-latest | |||
| arch: | |||
| - x64 | |||
| - aarch64 | |||
There was a problem hiding this comment.
This doesn't make sense without excluding the impossible combinations
There was a problem hiding this comment.
Yes, but I don't know enough about GHA on how to do that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29