Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FileCard): Adding new component FileCard #31

Merged
merged 19 commits into from
Sep 20, 2023
Merged

feat(FileCard): Adding new component FileCard #31

merged 19 commits into from
Sep 20, 2023

Conversation

Barsnes
Copy link
Contributor

@Barsnes Barsnes commented Sep 18, 2023

Resolved: #32

@Barsnes Barsnes marked this pull request as ready for review September 19, 2023 07:41
Copy link
Contributor

@Thunear Thunear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert! Eit par ting:

  • Sidan denne komponenten alltid skal brukast til nedlasting av filer, burde kanskje download proppen vore hardkoda inn?
  • Trur ikkje me trenger fileName, trenger kun path til nedlasting.
  • Endre subTitle til description.
  • aria-label trengs ikkje fordi teksten inne i lenka beskriver oppførsel,
  • Slik className er satt opp no, så får ikkje brukarar muligheten til å overstyre med sin eigen klasse.
  • Send ...rest med ned til komponenten slik at brukar-definerte props blir med.
  • Sidan brand typen er noko som ofte blir brukt, plasser den i ei "types" mappe.
  • Color css variablane for primary blir definert 2 gonger.
    * useIsMobile hooken, snakk med Jens og sjå om de får laga ein hook som returernerer eit object med {isMobile: true, isTablet: false}. Då sikrar me at breakpoints blir like på tvers av applikasjonar.

@Thunear Thunear merged commit 8683b87 into main Sep 20, 2023
2 checks passed
@Thunear Thunear deleted the feat/FileCard branch September 20, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: FileCard
2 participants