-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more careful to retry when the feature count is exceeded #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-n-f
requested review from
migurski,
arredond,
dnomadb,
ChrisLoer and
ibesora
as code owners
August 19, 2024 20:58
migurski
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on our 1:1 conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #227, where, because the ratio of base features to multiplier features can shift slightly over the course of a tile, a tile might exceed the feature count limit during the assembly of features but then might be judged to be below the limit by the end of the tile, causing the tile to be truncated rather than retried.
Now it explicitly checks when any features have been excluded for being over the limit and always retries the zoom level if any dynamic dropping options have been specified.
There was also a bug where features that were dropped onto a multiplier cluster rather than dropped entirely from the tile were not counted as having been dropped and did not prevent the zoom pyramid from being truncated. Such features are now counted as
dropped_as_needed
and prevent zoom pyramid truncation.In addition, it changes the
maxzoom
reported for tilesets generated with--generate-variable-depth-tile-pyramid
to be the highest zoom level at which tiles were actually generated, not the originally-specified maxzoom.It also changes the order of operations in
tippecanoe-overzoom
to clip features to just those that will be included in the output tile before doing any work related to filters or multiplier clusters.Finally, it allows the value of a
BUILD_INFO
environmental variable to be included in the--version
output andgenerator
metadata.