Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more careful to retry when the feature count is exceeded #257

Merged
merged 14 commits into from
Aug 20, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Aug 16, 2024

This fixes a regression introduced in #227, where, because the ratio of base features to multiplier features can shift slightly over the course of a tile, a tile might exceed the feature count limit during the assembly of features but then might be judged to be below the limit by the end of the tile, causing the tile to be truncated rather than retried.

Now it explicitly checks when any features have been excluded for being over the limit and always retries the zoom level if any dynamic dropping options have been specified.

There was also a bug where features that were dropped onto a multiplier cluster rather than dropped entirely from the tile were not counted as having been dropped and did not prevent the zoom pyramid from being truncated. Such features are now counted as dropped_as_needed and prevent zoom pyramid truncation.

In addition, it changes the maxzoom reported for tilesets generated with --generate-variable-depth-tile-pyramid to be the highest zoom level at which tiles were actually generated, not the originally-specified maxzoom.

It also changes the order of operations in tippecanoe-overzoom to clip features to just those that will be included in the output tile before doing any work related to filters or multiplier clusters.

Finally, it allows the value of a BUILD_INFO environmental variable to be included in the --version output and generator metadata.

@e-n-f e-n-f marked this pull request as ready for review August 19, 2024 20:58
Copy link
Collaborator

@migurski migurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on our 1:1 conversation

@e-n-f e-n-f merged commit 40bb4ff into main Aug 20, 2024
6 checks passed
@e-n-f e-n-f deleted the too-many-features-retry branch August 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants