Fix get_subjects_from_batch ignoring metadata #1131

KonoMaxi · 2023-12-04T15:47:58Z

Demonstrates ISSUE 1130.

Description

I added two test-cases which show what I described in issue 1130

Checklist

I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
Non-breaking change (would not break existing functionality)
Breaking change (would cause existing functionality to change)
Tests added or modified to cover the changes
Integration tests passed locally by running pytest
In-line docstrings updated
Documentation updated, tested running make html inside the docs/ folder
This pull request is ready to be reviewed

for more information, see https://pre-commit.ci

KonoMaxi mentioned this pull request Dec 4, 2023

get_subjects_from_batch has a hick-up with int metadata #1130

Closed

1 task

fepegar changed the title ~~added test that shows metadata issues~~ Fix get_subjects_from_batch ignoring metadata Jan 28, 2024

Max Konowski and others added 3 commits January 28, 2024 18:14

added test that shows metadata issues

cf4d13e

[pre-commit.ci] auto fixes from pre-commit.com hooks

708d3d7

for more information, see https://pre-commit.ci

Fix get_subjects_from_batch ignoring metadata

d04ca3c

fepegar force-pushed the 1130-subjects_from_batch-bug branch from 219485a to d04ca3c Compare January 28, 2024 18:14

fepegar merged commit f91f1b4 into fepegar:main Jan 28, 2024
10 of 13 checks passed

Provide feedback