-
Notifications
You must be signed in to change notification settings - Fork 0
New capability set #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New capability set #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new workflow for creating capability sets in FERRY, complete with verification steps and unit tests.
- Implements
NewCapabilitySetworkflow for group, unit, FQAN, and capability-set operations. - Enhances
FerryAPI.call_endpointandWorkflow.verify_outputfor better dry-run output and error handling. - Registers the new workflow and adds comprehensive tests for its methods.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_NewCapabilitySet.py | Added unit tests for NewCapabilitySet.run and its helpers |
| ferry_cli/helpers/workflows.py | Improved verify_output error handling and removed sys.exit |
| ferry_cli/helpers/supported_workflows/init.py | Registered NewCapabilitySet in the supported workflows mapping |
| ferry_cli/helpers/supported_workflows/NewCapabilitySet.py | Implemented the new capability-set workflow |
| ferry_cli/helpers/api.py | Updated dry-run logging in call_endpoint to include parameters |
| ferry_cli/main.py | Modified output handling condition to check json_result |
Comments suppressed due to low confidence (2)
tests/test_NewCapabilitySet.py:83
- Typo in test function name: 'test_NewCapabiilitySet_run' has an extra 'i'. Rename to 'test_NewCapabilitySet_run' for consistency with the class name.
def test_NewCapabiilitySet_run(args, expected, capsys):
ferry_cli/helpers/workflows.py:43
- [nitpick] The error message 'Failed to verify output' is generic and used for multiple failure cases; consider providing more specific messages or include context about the failure reason.
print("Failed to verify output")
…oken subject to be FERRY UID
cathulhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues and the replies to copilot comments make sense to me
Added workflow for creating a new capability set that mirrors https://github.com/DUNE/data-mgmt-ops/wiki/Dune-Physicsgroups-disk--how-to-create-a-new-physics-group
Also added tests for the workflow that ensure the correct APIs are getting called.
Closes #103