-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In preparation for future Spin 1.5 CLI #765
Conversation
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Just creating a PR with blank 1.5 code blocks in preparation for inevitable Spin 1.5 release. Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-765-rrso7lpj.fermyon.app |
Keep an eye out for possible updates at |
Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Please add any additional tasks/suggestions to the following list:
|
@tpmccallum cloud plugin 0.2.0 is now out, so the new |
Spin v1.5.0 is now out, as well as js2wasm v0.6.0 |
Thanks @vdice |
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - with two fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Thanks Tim!
content/spin/http-outbound.md
Outdated
|
||
## Granting HTTP Permissions to Components Within a Spin App | ||
|
||
> Components **within a Spin app can easily communicate with each other** via outbound http provided they are configured with `allowed_http_hosts = ["self"]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get GitHub to make this a suggestion because of embedded backticks, but here is a cough suggestion. Just aiming to clarify that self
is not only in allowed_http_hosts
and to build out a bit more info about the behaviour.
In an HTTP component, you can use the special host self
to make HTTP requests within the current Spin application. For example, if you make an outbound HTTP request to http://self/api/customers/
, Spin replaces self
with whatever host the application is running on. It also replaces the URL scheme (http
or https
) with the scheme of the current HTTP request. For example, if the application is running in the cloud, Spin changes http://self/api
to https://.../api
.
Using self
means that the application doesn't need to know the URL where it's deployed, or whether it's running locally versus in the cloud.
This doesn't work in Redis components because Spin uses the incoming HTTP request to determine the current host.
You must still grant permission by including self
in allowed_http_hosts
:
allowed_http_hosts = ["self"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan, this is REALLY helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in the new push.
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: Mikkel Mork Hegnhoj <12242001+mikkelhegn@users.noreply.github.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: Mikkel Mork Hegnhoj <12242001+mikkelhegn@users.noreply.github.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: Kate Goldenring <kate.goldenring@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: itowlson <ivan.towlson@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com
This PR just parks some of the work that Mung did on 1.5 tabs in code blocks; a PR with blank 1.5 code blocks in preparation for the inevitable Spin 1.5 release.
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,
template, and
date` are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep '^M' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors