WIP: POC for new sdk js lib implementation #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
poc/spin-sdk-library
branch
2 times, most recently
from
db80273
to
c8de545
Compare
radu-matei
reviewed
May 9, 2023
| */ | ||
| const spinSdk: SpinSdk = __internal__.spin_sdk | ||
| spinSdk.utils = utils | ||
| spinSdk.Router = () => { |
There was a problem hiding this comment.
nit: could we have Router as a top-level import from the SDK, instead of it being namespaced as spinSdk.Router?
radu-matei
approved these changes
May 9, 2023
karthik2804
force-pushed
the
poc/spin-sdk-library
branch
from
c8de545
to
233bdb3
Compare
karthik2804
force-pushed
the
poc/spin-sdk-library
branch
4 times, most recently
from
3b0c897
to
73d99a8
Compare
Merged
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
poc/spin-sdk-library
branch
from
73d99a8
to
fe449a6
Compare
dicej
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very work-in-progress implementation of the SDK lib. This PR attempts to replace the current
spin-sdkpackage which hosts only type to a package that provides implementations as well. This allows for there to be an explicit import of types in both ts/js as per #158.Currently, there are examples for both ts/js In
examples/javascript/sdk-poc-jsexamples/javascript/sdk-poc-tsThe advantage to this is that helper functions can be added without a need for there to be a new build of the plugin along with allowing us to create explicit imports allowing for the removal of magic imports.
The one downside to this approach is that there will be slightly more work maintaining both the code that is internal to the SDK as well as this package.
There definitely needs to be a lot more of the cleanup if this is an approach we want to pursue.
Thoughts?