Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build docs and add vs code settings #170

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Improve build docs and add vs code settings #170

merged 1 commit into from
Jun 26, 2023

Conversation

rylev
Copy link

@rylev rylev commented Jun 21, 2023

This would have saved me some headache when getting set up in this project.

@rylev rylev requested a review from karthik2804 June 21, 2023 13:22
@rylev
Copy link
Author

rylev commented Jun 22, 2023

Looks like something really funny is happening inside of the quickjs_wasm_rs::Context initialization. Seems like we're successfully creating a JS runtime but then creating the inner Context fails with a "out of bounds memory access". I can't reproduce this locally.

@karthik2804
Copy link
Collaborator

karthik2804 commented Jun 22, 2023 •
edited
Loading

@rylev I have been running into this as well. The solution seems to be to upgrade wizer

@rylev
Improve build docs and add vs code settings
2c5c12f 
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev merged commit 3053202 into main Jun 26, 2023
@rylev rylev deleted the improve-build-docs branch June 26, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicej dicej dicej approved these changes

@radu-matei radu-matei radu-matei approved these changes

@karthik2804 karthik2804 Awaiting requested review from karthik2804

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rylev @karthik2804 @dicej @radu-matei