add ci to test template #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
ci_test_templates
branch
from
805e145
to
de67986
Compare
vdice
reviewed
Jul 30, 2024
vdice
reviewed
Jul 30, 2024
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
ci_test_templates
branch
from
de67986
to
9d5122b
Compare
vdice
approved these changes
Jul 30, 2024
|
Will merge after I fix the failing |
|
I am thinking just building the app should be sufficient, do we also want to test running the app and getting a response? I do not have string preferences here. |
What you've added already seems great for now. Can be a follow-up if we end up wanting that coverage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.