Add environment variables provider #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Jul 22, 2024
| pub use statik::StaticVariables; | ||
|
|
||
| use serde::de::DeserializeOwned; | ||
| use spin_expressions::Provider; | ||
| use spin_factors::anyhow; | ||
|
|
||
| pub trait MakeVariablesProvider: 'static { |
There was a problem hiding this comment.
Do you think we should switch to the runtime resolver pattern here?
There was a problem hiding this comment.
That's the next PR 😄
There was a problem hiding this comment.
| /// no .env file is loaded. | ||
| pub fn new( | ||
| prefix: Option<impl Into<String>>, | ||
| env_fetcher: impl Fn(&str) -> Result<String, VarError> + Send + Sync + 'static, |
There was a problem hiding this comment.
Do we have a concrete need for this? Seems a bit marginal vs implementing an entirely new provider...
There was a problem hiding this comment.
It makes testing not rely on the environment it's run in. If it complicates too many things in your opinion, we can go back to just assuming std::env::variable.
There was a problem hiding this comment.
Maybe a separate with_env_fetcher? 🤷
rylev
commented
Jul 22, 2024
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
lann
approved these changes
Jul 22, 2024
|
I don't know why all these other checks ran. Feel free to ignore them and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
EnvVariablesprovider and moves the static provider to its own submodule. If this looks good, the next step is to implement the vault and azure extensions.