Add outbound MQTT factor #2722
Add outbound MQTT factor #2722
Conversation
| use spin_world::v2::mqtt::{self as v2, Connection, Error, Qos}; | ||
| use tracing::{instrument, Level}; | ||
|
|
||
| pub type CreateClient = Arc< |
There was a problem hiding this comment.
Looking at the other factors, we've normally been handling this pattern with custom trait trait objects rather than closure trait objects. So instead of this type alias we would do something like:
trait ClientCreator {
fn create(
address: String,
username: String,
password: String,
keep_alive_interval: Duration,
)
}
// ...
impl InstanceState {
pub fn new(allowed_hosts: OutboundAllowedHosts, create_client: Box<dyn ClientCreator>) {
// ...
| pub allowed_hosts: OutboundAllowedHosts, | ||
| pub connections: table::Table<Box<dyn MqttClient>>, | ||
| pub create_client: CreateClient, |
There was a problem hiding this comment.
We've been a little inconsistent about this but I wouldn't (necessarily) default to making these pub, which implies that they are part of the factor's public interface.
There was a problem hiding this comment.
I agree - in the spirit of trying to treat these as reusable libraries, we should be as careful as possible about only exposing the absolute minimum we need.
| dyn Fn(String, String, String, Duration) -> Result<Box<dyn MqttClient>, Error> + Send + Sync, | ||
| >; | ||
| #[async_trait] | ||
| pub trait ClientCreator: Send + Sync { |
There was a problem hiding this comment.
Let's not forgot documentation here! We can do that in a follow up though.
Co-authored-by: rylev <ryan.levick@fermyon.com> Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
|
I rebased... |
This PR adds the outbound-mqtt factor along with the associated tests.