Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factors: Get spin up working #2725

Merged
merged 1 commit into from
Aug 19, 2024
Merged

factors: Get spin up working #2725

merged 1 commit into from
Aug 19, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Aug 19, 2024

This is a minimal patch to get spin up working:

  • Comment out references to the not-yet-ported redis trigger
  • Replace TodoComponentLoader with SimpleComponentLoader; some functionality still missing

@lann
factors: Get spin up working
d0f1873 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested a review from rylev August 19, 2024 14:30
rylev
rylev approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lann lann merged commit fde04a6 into fermyon:factors Aug 19, 2024
2 checks passed
@lann lann deleted the spin-up-factors branch August 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @rylev