Simplify default database resolution in sqlite #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of treating the SQLite Factor's runtime config as 1 on 1 the same as the Spin CLI runtime config toml, we inject handling of the "default" label into the factor's runtime config struct. This makes handling of label resolution happen in just one place instead of spliting it into two. Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
|
@rylev Just to confirm I'm reading the code right: this doesn't change the user experience, right? It's solely moving the implementation of that user experience to a different part of the code. |
lann
approved these changes
Sep 17, 2024
|
@itowlson correct if by "user" you mean "user of the Spin CLI" - this is purely a library change so it will change the experience for those using Spin as a library building their own Spin compliant runtime. |
|
@rylev Yes, sorry, I should have been clearer. Thanks for clarifying - sounds good! |
rylev
force-pushed
the
simplify-default-sqlite
branch
from
5d38fcb
to
f8245ba
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
simplify-default-sqlite
branch
from
f8245ba
to
4d50c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies how labels are resolved to connection creators in
factor-sqlite.Instead of treating default labels as something special, the factor loses all knowledge of "default" labels. The label to connection creator mapping resides entirely inside of the factor's runtime config. The sqlite factor's runtime config was previously responsible for label to connection creator mapping for all database labels except for the default one. Now it handles the default one as well.
This removes the very notion of a "default" labeled database from the factor and instead moves that to a higher level concern (how the runtime configures each factors runtime config).
The tests for the sqlite factor have also be massively simplified as they no longer use the Spin CLI's notion of runtime config toml and instead just supply the runtime config directly. This makes it much easier to understand the what the test is actually testing.
If you're happy with this approach, I'd like to also do the same thing for key-value.