Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger: Decouple Trigger from clap #2864

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

trigger: Decouple Trigger from clap #2864

wants to merge 2 commits into from
+47 −32

Commits on Sep 27, 2024

  1. trigger: Re-export a few things to ease trigger development 

    Signed-off-by: Lann Martin <lann.martin@fermyon.com>
    @lann
    lann committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    416434b View commit details
    Browse the repository at this point in the history

  2. trigger: Decouple Trigger from clap 

    - Rename `Trigger`'s associated `CliArgs` type to `GlobalConfig`
- Move that `clap::Args` bound into `FactorsTriggerCommand`
- Fix up related code

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
    @lann
    lann committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3c86968 View commit details
    Browse the repository at this point in the history