feat(run.sh): add spin version tag #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to add the spin version as a variable to the dashboard as well? eg https://github.com/kate-goldenring/performance/blob/main/.github/workflows/aks.yaml#L75-L79 |
tests/run.sh
Outdated
| OUTPUT=${OUTPUT:-"datadog"} | ||
| export TAG_SPIN_VERSION="${SK_OCI_TAG}" |
There was a problem hiding this comment.
I don't think we assume these are always the same. For example, for density tests we use latest. Maybe we support passing SPIN_VERSION to the script and default to SK_OCI_TAG?
There was a problem hiding this comment.
Ah right, thank you. Updated.
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
feat/add-spin-version-tag
branch
from
682ea48 to
2d67e93
Compare
kate-goldenring
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41