-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the min/max parsing to check for empty attributes #18
Open
gingerchew
wants to merge
9
commits into
ferndot:main
Choose a base branch
from
gingerchew:fix-empty-minmax-attr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 026c941 - Browse repository at this point
Copy the full SHA 026c941View commit details
Commits on Jul 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4bf13e5 - Browse repository at this point
Copy the full SHA 4bf13e5View commit details -
Adds abstraction to attribute validation
Since the check inside the if statement would grow to 3 checks, makes sense to move those into a variable check that for readability.
Connor Wilson committedJul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for fdcb3ba - Browse repository at this point
Copy the full SHA fdcb3baView commit details -
Adds ignore rule for the .yarn folder
Connor Wilson committedJul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for ab3fadd - Browse repository at this point
Copy the full SHA ab3faddView commit details -
Adds ignore rule for .yarnrc.yml
Connor Wilson committedJul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 8974c66 - Browse repository at this point
Copy the full SHA 8974c66View commit details -
New files generated from the Yarn v2 Compatibility
Connor Wilson committedJul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for d717292 - Browse repository at this point
Copy the full SHA d717292View commit details -
Connor Wilson committed
Jul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for dbcc32c - Browse repository at this point
Copy the full SHA dbcc32cView commit details -
New build to include min/max fallback
Connor Wilson committedJul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for c7d3074 - Browse repository at this point
Copy the full SHA c7d3074View commit details -
Connor Wilson committed
Jul 12, 2023 Configuration menu - View commit details
-
Copy full SHA for b599358 - Browse repository at this point
Copy the full SHA b599358View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.