This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
take Implementation by reference
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listochkin
approved these changes
Feb 26, 2024
japaric
force-pushed
the
ja-impl-by-ref
branch
from
6bed1e2 to
a223fd1
Compare
this eliminates the need for cloning in tests that use more than one name server, making the code more succint / less noisy
mainly for symmetry. the existing tests don't clone the subject so the code does not become any shorter
japaric
force-pushed
the
ja-impl-by-ref
branch
from
a223fd1 to
ab9b1e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of by value to make the code shorter