This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
support using BIND in the Resolver role #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justahero
reviewed
Mar 7, 2024
| let pidfile = match self.implementation { | ||
| Implementation::Bind => "/tmp/named.pid", | ||
| Implementation::Unbound => "/run/unbound.pid", | ||
| Implementation::Hickory(..) => unimplemented!(), |
There was a problem hiding this comment.
Currently this will not cause an issue, because hickory is not used as a name server yet?
There was a problem hiding this comment.
correct
I was thinking of a different match statement so this answer was not correct. this unimplemented! is not a problem per se because no conformance test uses terminate. terminate is meant to be used to debug issues in tests, i.e. tests not behaving as expected. in the case of hickory, terminate simply has not yet been implemented but I'm currently working on it
There was a problem hiding this comment.
I'm currently working on it
implemented in #42
justahero
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.