This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Refactor test helpers #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NameServer can now return the `Record::A` entry for itself.
* fix clippy lints
This adds a function to `NameServer` to return root hints.
japaric
force-pushed
the
refactor-test-helpers
branch
from
b0f6614 to
0ea1397
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a few small things to hopefully improve readability of the tests somewhat.
Often a pair of
fqdn&ipv4_addrfor a given name server are used to set upArecords, therefore a method inNameServercan be used instead to produce this record. Similar the root hint can be returned from aNameServer.