Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_construction.py #656

Closed
wants to merge 1 commit into from
Closed

Conversation

tadash10
Copy link
Contributor

@tadash10 tadash10 commented Dec 1, 2023

#538 "theoretical proposal for changes" I'm still learning about modularity, so I decided on this file called test

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

festim-dev#538 "theoretical proposal for changes" I'm still learning about modularity, so I decided on this file called test
@RemDelaporteMathurin
Copy link
Collaborator

Hi @tadash10 thanks for this.

It is hard to understand what this PR is doing.

I think @jhdark just showed an example of using @pytest.mark.mpi and @pytest.mark.serial to differentiate between tests that need to be run in serial or in parallel.

Also the tests don't pass, you could try to run this locally to debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants