libp2p: fix for slow dht lookups using extra queue #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v0.7.1
Release v0.7.2
Release v0.7.3
Release v0.7.4
Release v0.7.5
Release v0.8.0
Release v0.9.0
Release v0.9.1
Release v0.9.2
Release v0.10.0
Release v0.10.1
solarw
force-pushed
the
fix/libp2p_slow_dht_lookups
branch
3 times, most recently
from
c62d5da
to
a1f9dc8
Compare
solarw
force-pushed
the
fix/libp2p_slow_dht_lookups
branch
2 times, most recently
from
493af30
to
c96dda0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2642 +/- ##
============================================
+ Coverage 99.91% 100.00% +0.08%
============================================
Files 521 516 -5
Lines 35888 35874 -14
============================================
+ Hits 35858 35874 +16
+ Misses 30 0 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
solarw
force-pushed
the
fix/libp2p_slow_dht_lookups
branch
4 times, most recently
from
27d6b9f
to
0664c3d
Compare
solarw
force-pushed
the
fix/libp2p_slow_dht_lookups
branch
from
0664c3d
to
5d6fe9a
Compare
…2p_slow_dht_lookups
…2p_slow_dht_lookups
…2p_slow_dht_lookups
…p_slow_dht_lookups
…2p_slow_dht_lookups
jrriehl
reviewed
Dec 13, 2021
| with open(self.conn.node.log_file) as f: | ||
| return "while sending slow envelope:" in f.read() | ||
|
|
||
| wait_for_condition(_check, timeout=30, period=1) |
There was a problem hiding this comment.
As I understand it, this will throw a timeout exception if the slow queue is not used, but since this is inside a try-except, won't the test always pass?
There was a problem hiding this comment.
it's try..finally to disconnect the connection in case of fail, no exceptions handled or supressed
jrriehl
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
libp2p: fix for slow dht lookups using extra queue
slow dht lookup envelopes are moved to slow queue to avoid blocking of "good" envelopes
Fixes
#2634
Types of changes
Checklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR
Release summary
Version number: [e.g. 1.0.1]
Release details
Describe in short the main changes with the new release.
Checklist
Put an
xin the boxes that apply.mainbranch (left side), fromdevelopscripts/generate_ipfs_hashes.py)HISTORY.mdfor this releaseaea/__version__.pyfile.latest(check the READMEs of
aea-developand
aea-user)aeato PyPI.Further comments
Write here any other comment about the release, if any.