Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing unnecessary software upgrade handlers #370

Merged

Conversation

pbukva
Copy link
Collaborator

@pbukva pbukva commented Jun 14, 2024

No description provided.

@pbukva pbukva self-assigned this Jun 14, 2024
@pbukva pbukva changed the base branch from master to feat/aasi-merger-cmd June 14, 2024 08:43
Copy link
Contributor

@MissingNO57 MissingNO57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, bud!

@pbukva
Copy link
Collaborator Author

pbukva commented Jun 14, 2024

Strictly speaking, the software upgrade handler is not required when starting fresh eon - starting from fresh genesis with erased node databases.
Because of that, the upgrade handler (for particular software gov proposal label) is not actually engaged/executed when the chain is started with new version of fetchd node.

==> If we land this PR, it will be just for cosmetic, not pratcical, reasons.

@pbukva pbukva changed the title feat: Adding v0.12.0 upgrade handler feat: Removing unnecessary software upgrade handlers Jun 17, 2024
@pbukva
Copy link
Collaborator Author

pbukva commented Jun 17, 2024

As per note above, we went with simplest possible way - dropping everthing what is not necessary = all upgrade handlers have been removed.

@pbukva pbukva merged commit 1bc7ecf into fetchai:feat/aasi-merger-cmd Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants